> On Aug. 26, 2016, 5:39 p.m., Gabor Szadovszky wrote: > > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java, > > line 101 > > <https://reviews.apache.org/r/51334/diff/1/?file=1482090#file1482090line101> > > > > Does it make sense to add an empty string to the StringBuilder?
No, it is not really necessary. You only have to add a separator if the value is null. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51334/#review146985 ----------------------------------------------------------- On Aug. 23, 2016, 2:45 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51334/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2016, 2:45 p.m.) > > > Review request for hive, Naveen Gangam, Peter Vary, Sergio Pena, and Szehon > Ho. > > > Bugs: HIVE-14404 > https://issues.apache.org/jira/browse/HIVE-14404 > > > Repository: hive-git > > > Description > ------- > > Changed the class which is used to generate the output for the formats > 'csv2', 'tsv2' and 'dsv' not to use SuperCSV any more and support multiple > characters as delimiter. > The class implements the same escaping logic as it had with SuperCSV if the > quoting is not disabled. > Extended the TestBeeLineWithArgs tests with new test steps which are using > multiple characters as delimiter. > > This review is a follow-up for the review 50896. > > > Diffs > ----- > > beeline/pom.xml dc89e81 > beeline/src/java/org/apache/hive/beeline/BeeLine.java e0fa032 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java e6e24b1 > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java > 66d9fd0 > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 49c1120 > > Diff: https://reviews.apache.org/r/51334/diff/ > > > Testing > ------- > > - Tested manually in BeeLine. > - Extended the TestBeeLineWithArgs tests with new test steps which are using > multiple characters as delimiter. > > > Thanks, > > Marta Kuczora > >
