----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51568/#review147602 -----------------------------------------------------------
Ship it! Thanks for the patch. LGTM. - Gabor Szadovszky On Sept. 1, 2016, 12:21 a.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51568/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2016, 12:21 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-13555 > https://issues.apache.org/jira/browse/HIVE-13555 > > > Repository: hive-git > > > Description > ------- > > * adds nullif(a,b) udf > * argument converion is (i think) compatible with 'case when' > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > 69a18cd3b4e383f5f7eb9b8cbffd133b13b5a595 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNullif.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNullif.java > PRE-CREATION > ql/src/test/queries/clientpositive/udf_nullif.q PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out > 68c24a6fc108cb30253b5ca462e5d4680e58b84a > ql/src/test/results/clientpositive/udf_nullif.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/51568/diff/ > > > Testing > ------- > > addedd some unit cases + qtest > > > Thanks, > > Zoltan Haindrich > >
