> On Aug. 31, 2016, 6:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java, > > line 286 > > <https://reviews.apache.org/r/51542/diff/1/?file=1488888#file1488888line286> > > > > Will STRUCT with all constants inside e.g. (x, y) in (1,2), be handled > > correctly by this code block? In that case, (1, 2) should be considered a > > constant, thus we could remove the IN. However, I think currently we will > > end up with UNKNOWN state and we will never remove it. I think that was a > > case that we were supporting previously, thus it would be a regression. > > Could you double check?
Those are handled elsewhere. See pointlookup tests where they are removed > On Aug. 31, 2016, 6:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java, > > line 375 > > <https://reviews.apache.org/r/51542/diff/1/?file=1488888#file1488888line375> > > > > WalkState.CONSTANT or WalkState.UNKNOWN? (I think in this case it > > should be the latest) this is existing code moved as is :) - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51542/#review147456 ----------------------------------------------------------- On Aug. 30, 2016, 9:56 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51542/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 9:56 p.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java > f9388e2 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java b2125ca > ql/src/test/queries/clientpositive/partition_condition_remover.q > PRE-CREATION > ql/src/test/results/clientpositive/partition_condition_remover.q.out > PRE-CREATION > ql/src/test/results/clientpositive/pcs.q.out 0045c1c > > Diff: https://reviews.apache.org/r/51542/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
