> On July 28, 2016, 4:37 a.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java, line 627 > > <https://reviews.apache.org/r/50510/diff/1/?file=1455259#file1455259line627> > > > > Adding @Ignore may not be the right solution here. This will skip > > saving the conf variable which can potentially lead to loss of user's > > custom settings for HiveConf. > > > > The issue is caused because the method name is setHiveConf while the > > Reflector is looking for setConf. Did you try renaming the method from > > setHiveConf to setConf? > > Peter Vary wrote: > You are correct, but this variable is only used in BeeLine compatibility > mode (in BeeLine mode it is not possible to initialize the HiveConf object), > and then it contains every hiveconf variable set on the server, above the > ones set by the user. I do not think it is a good idea to store this in a > configuration file, and will not work, since when initialized, these are > overwritten by the server when the connection is estabilished > (beeLine.updateOptsForCli()). > > What do you think?
Thanks for the clarification. - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50510/#review143886 ----------------------------------------------------------- On July 27, 2016, 4:26 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50510/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 4:26 p.m.) > > > Review request for hive, Aihua Xu, Sergio Pena, and Vihang Karajgaonkar. > > > Bugs: HIVE-14360 > https://issues.apache.org/jira/browse/HIVE-14360 > > > Repository: hive-git > > > Description > ------- > > Adding the @Ignore annotation to the getConf method, so the saving should > ignore the attribute > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java e6e24b1 > beeline/src/test/org/apache/hive/beeline/TestBeeLineOpts.java PRE-CREATION > > Diff: https://reviews.apache.org/r/50510/diff/ > > > Testing > ------- > > Manually + unit test > > > Thanks, > > Peter Vary > >
