----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51119/#review146136 -----------------------------------------------------------
Fix it, then Ship it! The rest of the changes look good to me. ql/src/test/queries/clientpositive/union_type_chk.q (line 7) <https://reviews.apache.org/r/51119/#comment212512> Not related to your change, but this could end up being a flaky test in future because of the limit clause without an order by. - Hari Sankar Sivarama Subramaniyan On Aug. 18, 2016, 9:47 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51119/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 9:47 p.m.) > > > Review request for hive, Hari Sankar Sivarama Subramaniyan and Siddharth Seth. > > > Bugs: HIVE-14503 > https://issues.apache.org/jira/browse/HIVE-14503 > > > Repository: hive-git > > > Description > ------- > > HIVE-14503: Remove explicit order by in qfiles for union tests > > > Diffs > ----- > > ql/src/test/queries/clientpositive/union23.q > 052f34a92ec4397411501c2fa58d46b3bed2ae5a > ql/src/test/queries/clientpositive/union32.q > f47f0afae2dba196da285d73de879c6c6ab91da3 > ql/src/test/queries/clientpositive/union34.q > 2ab16de307a6c624d11bc0cd9ca5ef9926c1c6a1 > ql/src/test/queries/clientpositive/union36.q > c38e7b1287fe0f28cc3176558b5f35070c8e00c5 > ql/src/test/queries/clientpositive/unionDistinct_1.q > 0d53a961a4d9fb55eadcd8226598f5c75eb964b4 > ql/src/test/queries/clientpositive/union_remove_1.q > 702f71a66d18c52e96cd28fb5dc07a3b3babad38 > ql/src/test/queries/clientpositive/union_remove_10.q > 508f3540d04caa8cfb603a83e4c91ea5a8dcef2f > ql/src/test/queries/clientpositive/union_remove_11.q > bdfbf66a4419e52aea474cd5cdb8ea75e9410dd9 > ql/src/test/queries/clientpositive/union_remove_12.q > f6436f5e979b90403d8ec342d69c4e25382866c3 > ql/src/test/queries/clientpositive/union_remove_13.q > b02451b0458a6c79c28d8d4f0f0c894a9f0e11cb > ql/src/test/queries/clientpositive/union_remove_14.q > bec622605e0f04afbc23e61b7025727f2040e6da > ql/src/test/queries/clientpositive/union_remove_15.q > e38473975703d662a2937fdd925562f2eed9ade0 > ql/src/test/queries/clientpositive/union_remove_16.q > 41305bfe3f5689ed07ed0d500639515c09c56f0b > ql/src/test/queries/clientpositive/union_remove_17.q > 8f91d03e4046682577ac7a59f19db3f70ce64c1a > ql/src/test/queries/clientpositive/union_remove_18.q > ad38742ecd845c5b1f0a122c05f3bf3a339a445b > ql/src/test/queries/clientpositive/union_remove_19.q > 34f8b5a2427b7a40c5f990edc2372f6664bbcf7e > ql/src/test/queries/clientpositive/union_remove_2.q > 274608cb0b2b546b3a4916e68ff2a118abfea364 > ql/src/test/queries/clientpositive/union_remove_20.q > 93a49f3bebe5667e0f76948d6494c91b35c3ca0d > ql/src/test/queries/clientpositive/union_remove_21.q > fa8ff2731d0d4c2e26b12e50c2cb6432cb57f43d > ql/src/test/queries/clientpositive/union_remove_22.q > 0e97cae8099b9ef96f8648c846f8aa106a4a7080 > ql/src/test/queries/clientpositive/union_remove_24.q > 3a1e2257b03b7df770dbb27cc77bd59999e665b8 > ql/src/test/queries/clientpositive/union_remove_25.q > d70adb959571854f0d817ebbbd5b6121b4194268 > ql/src/test/queries/clientpositive/union_remove_26.q > d35d4e259afd0643ab2535f299731654c6c8a627 > ql/src/test/queries/clientpositive/union_remove_3.q > 2e6e3e665843eb6741ff40491ad6bfaa0a804e29 > ql/src/test/queries/clientpositive/union_remove_4.q > a08bcc194dd00d42a94e821a593800ae2e7d21b2 > ql/src/test/queries/clientpositive/union_remove_5.q > 4ac3edf0711ed63e50ace2ca6c06a0fe89b762d8 > ql/src/test/queries/clientpositive/union_remove_6.q > f37f409d22802f551fd32884fafc052693445479 > ql/src/test/queries/clientpositive/union_remove_6_subq.q > 68537280efa4636e1adece2d004366fcece5360e > ql/src/test/queries/clientpositive/union_remove_7.q > cd6a75a125c6835910bbf93fdc4000e558484af3 > ql/src/test/queries/clientpositive/union_remove_8.q > 93aabe618d0b76f77e5c9386a20958e5c42a9d81 > ql/src/test/queries/clientpositive/union_remove_9.q > 1bb8d6d7b779b40960c8b1bcd9284fdb458f1384 > ql/src/test/queries/clientpositive/union_script.q > 76871048556eda87ec5823e913e317219ba1ec16 > ql/src/test/queries/clientpositive/union_type_chk.q > a25aedadc3c04d317fcb15dc8108a63643ce6513 > ql/src/test/queries/clientpositive/union_view.q > fa394508cb829a7d78e9816108c37f30ce6d347f > ql/src/test/results/clientpositive/spark/union32.q.out > 09fb01ea7660ee079aa59676a1b656516024cc5f > ql/src/test/results/clientpositive/spark/union34.q.out > 1a50c3cc10ee68116fa722f1dce77b7086dae1a5 > ql/src/test/results/clientpositive/spark/union_remove_1.q.out > 6d88345381fc5807f8a6bdf7c0ce08467a7abe61 > ql/src/test/results/clientpositive/spark/union_remove_10.q.out > 7b4b0c41e48955935afcf6878ad017048f571bc1 > ql/src/test/results/clientpositive/spark/union_remove_11.q.out > 5d77d06493dab4562e89726ccb056c11d72fab3d > ql/src/test/results/clientpositive/spark/union_remove_12.q.out > 6a7fe69c96c01e7a42b01a0b017ce06724fc461e > ql/src/test/results/clientpositive/spark/union_remove_13.q.out > 2d031f99d91cf3200f55673d16fbe15afbc88b04 > ql/src/test/results/clientpositive/spark/union_remove_14.q.out > 0be3d8602b27a772ce99168b8ac98013586701d2 > ql/src/test/results/clientpositive/spark/union_remove_15.q.out > c0ad4e692f38753386a3901290a4e591b6b95d5d > ql/src/test/results/clientpositive/spark/union_remove_16.q.out > d02109ae87fea1ed9546adb9ff8a36c7a1288897 > ql/src/test/results/clientpositive/spark/union_remove_17.q.out > c8047a9ceedf21dfee506a936e02e5e163259e3f > ql/src/test/results/clientpositive/spark/union_remove_18.q.out > 6a6de9235468fd5be61dd6000102bae9ffbcee9d > ql/src/test/results/clientpositive/spark/union_remove_19.q.out > 59063a7627c10740c9c958141846611b47ff95cf > ql/src/test/results/clientpositive/spark/union_remove_2.q.out > 4667e7002db78b4a22da80a2c07d2a3870489606 > ql/src/test/results/clientpositive/spark/union_remove_20.q.out > b7682a9fb156a33036d070cd55b8fa61649d1f5c > ql/src/test/results/clientpositive/spark/union_remove_21.q.out > c9bcf36e981c3257fd44005021779e1d5840bf33 > ql/src/test/results/clientpositive/spark/union_remove_22.q.out > 90caa890fcfb642ab3cf38b9e2feceacc04cc507 > ql/src/test/results/clientpositive/spark/union_remove_23.q.out > 3d51af5d30beed1db7cbdd5596c48f512eaa87e6 > ql/src/test/results/clientpositive/spark/union_remove_24.q.out > 94f71ac9158e3e6c38f4e8113937833352ba56db > ql/src/test/results/clientpositive/spark/union_remove_25.q.out > eb95cadde3f8f3006df4a1093bebf00dd55514f8 > ql/src/test/results/clientpositive/spark/union_remove_3.q.out > 66675cef944ee06734eef354f43ca2c65f94e5fa > ql/src/test/results/clientpositive/spark/union_remove_4.q.out > 1bf917ab0e14b7aa3230a891869781f69e76dbed > ql/src/test/results/clientpositive/spark/union_remove_5.q.out > aabb6c4b5b3ad0bf50a596a080d59cd0b278be41 > ql/src/test/results/clientpositive/spark/union_remove_6.q.out > d677d1bb0281ecc6d967c9ccde63a2b7cd77c68c > ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out > dac8247945b79f3d28ca685e44dcddbb041abbca > ql/src/test/results/clientpositive/spark/union_remove_7.q.out > 6af69e0eaffcb554d1c82e8ef7e2bf230db40afb > ql/src/test/results/clientpositive/spark/union_remove_8.q.out > f19afad59877ad64c93eb4780fb7ef2621988b71 > ql/src/test/results/clientpositive/spark/union_remove_9.q.out > 2e2abf986b3e8a2826681d3efabe65709bea5cb0 > ql/src/test/results/clientpositive/spark/union_script.q.out > e044f630af9f9bb2264b36923679c26920a981de > ql/src/test/results/clientpositive/spark/union_view.q.out > 892cc6f3e9a023d50125dfab60967b124e96571a > ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out > dd78248b82104c38eb9e613a0c38f051f04adda8 > ql/src/test/results/clientpositive/tez/union_type_chk.q.out > 12f060bb23819919aaf5ca73aa18f37db4f254e2 > ql/src/test/results/clientpositive/union32.q.out > f61a31371d621bb9168105e7fd91806e3b664b07 > ql/src/test/results/clientpositive/union34.q.out > 06f75e70b4facdc211a35c0ea14031b48b3e75c6 > ql/src/test/results/clientpositive/union36.q.out > 12f060bb23819919aaf5ca73aa18f37db4f254e2 > ql/src/test/results/clientpositive/unionDistinct_1.q.out > 1d32a060c1267751c940c2512cac54a645235d92 > ql/src/test/results/clientpositive/union_remove_1.q.out > 1bd471d9113d54ad8e6c4c978c40c4634fad42e6 > ql/src/test/results/clientpositive/union_remove_10.q.out > 14645f08fc13ab8c535dc8316d43ddfa3847feba > ql/src/test/results/clientpositive/union_remove_11.q.out > 5696383a34768fc830c531f8b3c7a525c9be8180 > ql/src/test/results/clientpositive/union_remove_12.q.out > 1aa21eb5fde978f752091992b99ff4f313a61050 > ql/src/test/results/clientpositive/union_remove_13.q.out > 1bf411ff20d6ebbead698e43816d689bec3213e8 > ql/src/test/results/clientpositive/union_remove_14.q.out > 6c89b92fe36fa2d61bbcf2072015fe89c2a0a5e6 > ql/src/test/results/clientpositive/union_remove_15.q.out > a259df882f8dee1d27450a8f85dbc0c6dba48662 > ql/src/test/results/clientpositive/union_remove_16.q.out > c7a08f3495094730dc2bcaaac7da041850365054 > ql/src/test/results/clientpositive/union_remove_17.q.out > 688e365075d8c07ce34d41a38f4f6cd156df7c7f > ql/src/test/results/clientpositive/union_remove_18.q.out > 96daa12f33c32ab0c1607ab701b96c1d92e127f0 > ql/src/test/results/clientpositive/union_remove_19.q.out > 1a40efaec2645e83deb9cc78821a47de9cff6e7a > ql/src/test/results/clientpositive/union_remove_2.q.out > e5de3c6299fa8a6a20b7b27bb7eff867adf9b8f4 > ql/src/test/results/clientpositive/union_remove_20.q.out > 96d76d40c1bf63fcd957d25f00be56589eb0cf95 > ql/src/test/results/clientpositive/union_remove_21.q.out > 13567774fcc457c93acc6592206ec0be97ed4542 > ql/src/test/results/clientpositive/union_remove_22.q.out > 933a0e859c5b89ae3703049df8b7531b982f7588 > ql/src/test/results/clientpositive/union_remove_23.q.out > b00e5d1edac279145b79162fa448ca4ce539b2ee > ql/src/test/results/clientpositive/union_remove_24.q.out > 95bf66b7ccec926d5394e83a4328d2e1db12e9dc > ql/src/test/results/clientpositive/union_remove_25.q.out > 3869735f9f83a1c5538403f5563369eee7d77be9 > ql/src/test/results/clientpositive/union_remove_3.q.out > a95a48e938c628a0d6774882c3c969fdf720a81c > ql/src/test/results/clientpositive/union_remove_4.q.out > 818ae805ca4232da6517cf498707a5f790eccbc8 > ql/src/test/results/clientpositive/union_remove_5.q.out > d6c2b99ef20a1a0d1081420dd9a2d87116f967bd > ql/src/test/results/clientpositive/union_remove_6.q.out > 1b076c2f3ea2f34e0a38e3ea8a2024d04d147f50 > ql/src/test/results/clientpositive/union_remove_6_subq.q.out > b1e79e7c5539aad61ddaa3a16ba9e4ced0cdcb21 > ql/src/test/results/clientpositive/union_remove_7.q.out > 5541cb0a0a48d76ae22c9fe71ef009e0c15a7068 > ql/src/test/results/clientpositive/union_remove_8.q.out > 22e6f1596c7d855bc4e9e24d2467ca34a8c7e280 > ql/src/test/results/clientpositive/union_remove_9.q.out > 70b5ee9a9f6593af435885b6ec3e4a1f47a165bc > ql/src/test/results/clientpositive/union_script.q.out > e044f630af9f9bb2264b36923679c26920a981de > ql/src/test/results/clientpositive/union_type_chk.q.out > 12f060bb23819919aaf5ca73aa18f37db4f254e2 > ql/src/test/results/clientpositive/union_view.q.out > 2c30f0d0a53360f1594f9991e12d940348f445d7 > > Diff: https://reviews.apache.org/r/51119/diff/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
