----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50768/#review144773 -----------------------------------------------------------
Thanks for simpilying this, dropping the velocity/ant dependency is really appreciated. itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java (line 191) <https://reviews.apache.org/r/50768/#comment210886> Do we need a static initializer for srcTables? I can't find it being referenced from a static context. Couldn't we have an instance variable initialized in the constructor instead of having it rebuilt every time? - Barna Zsombor Klara On Aug. 3, 2016, 8:56 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50768/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 8:56 p.m.) > > > Review request for hive. > > > Bugs: HIVE-14415 > https://issues.apache.org/jira/browse/HIVE-14415 > > > Repository: hive-git > > > Description > ------- > > i'm using mostly the same code as QTestGenTask...I even made some of it's > filter accessible for now. > > this patch also contains the upgrade of TestPerfCliDriver to junit4...which > may make it a bit less readable. > > other changes: > > * HIVE_ROOT is detected by the existence of some specific directories > * hadoop_version is parsed from a jar instead of using some external property > > > Diffs > ----- > > ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java > f372d7cb937d91c10d3dff0e4c51e0849c5e3c9b > itests/qtest/pom.xml 17968e69559a16a1971f6028ea3073ab693a6678 > > itests/qtest/src/test/java/org/apache/hadoop/hive/cli/AbstractCliConfig.java > PRE-CREATION > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > b3cf6da56eddc5000515e5ebd34989e64b1c0010 > ql/src/test/templates/TestPerfCliDriver.vm > d2946cb4f9a7e3e9f8b3cc14a75802a483e7f95a > > Diff: https://reviews.apache.org/r/50768/diff/ > > > Testing > ------- > > i've already run it "alone" using maven - all the 60 cases have passed. > > > Thanks, > > Zoltan Haindrich > >
