> On July 25, 2016, 6:29 p.m., Sergey Shelukhin wrote: > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java, line 206 > > <https://reviews.apache.org/r/50401/diff/1/?file=1451946#file1451946line206> > > > > should this be "columns.get..."?
Yes, you r right. > On July 25, 2016, 6:29 p.m., Sergey Shelukhin wrote: > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java, line 109 > > <https://reviews.apache.org/r/50401/diff/1/?file=1451946#file1451946line109> > > > > nit: Hive standard limits lines to 100 characters... all these comments > > need not be reformatted. Can you update your editor preferences? ;) I double checked my code format. It is really 100 characters per line. > On July 25, 2016, 6:29 p.m., Sergey Shelukhin wrote: > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java, line 267 > > <https://reviews.apache.org/r/50401/diff/1/?file=1451946#file1451946line267> > > > > why trace and not at least info? I remembered that I discussed this with Ashutosh and he recommended to use trace.. - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50401/#review143407 ----------------------------------------------------------- On July 25, 2016, 6:14 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50401/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 6:14 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-14317 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 01e6010 > > Diff: https://reviews.apache.org/r/50401/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
