> On July 8, 2016, 9:24 p.m., Peter Vary wrote: > > I have checked your code, and I think it is nice, and clean. > > I think we should add the new parameter to > > beeline/src/main/resources/BeeLine.properties, and later in the > > documentation. > > > > Keeping in mind, that I am new to hive, I think you patch is otherwise good. > > > > Thanks, > > Peter
Thanks for the review Peter! I have updated the `BeeLine.properties` file so that the `--help` option displays the new parameter. I will investigate how to update the external documentation. - Sahil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49782/#review141335 ----------------------------------------------------------- On July 11, 2016, 5:29 p.m., Sahil Takiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49782/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 5:29 p.m.) > > > Review request for hive, Sergio Pena, Thejas Nair, and Vaibhav Gumashta. > > > Bugs: HIVE-14170 > https://issues.apache.org/jira/browse/HIVE-14170 > > > Repository: hive-git > > > Description > ------- > > * Added a new BeeLine Options called `incrementalBufferRows` which controls > the number of `Row`s the `IncrementalRows` class should buffer, by default it > is 1000 > * Modified `BufferedRows` so that it can accept a limit on the number of > `Row`s it buffers > * Modified `IncrementalRows` to read the value of `incrementalBufferRows` and > buffer rows as per HIVE-14170 > * The class delegates all buffering work to a `BufferedRows` class > * This has the advantage that all the width calculaltion that spans multiple > rows can be encapsulate in the `BufferedRows` class, there is no need to > re-implement the logic in `IncrementalRows` > * `IncrementalRows` will buffer `incrementalBufferRows` rows at a time, when > the buffer is depleted, it will fetch the next buffer and re-calculate the > width for that buffer > > > Diffs > ----- > > beeline/pom.xml a720d08 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 5aaa385 > beeline/src/java/org/apache/hive/beeline/BufferedRows.java 962c531 > beeline/src/java/org/apache/hive/beeline/IncrementalRows.java 8aef976 > beeline/src/java/org/apache/hive/beeline/Rows.java 453f685 > beeline/src/main/resources/BeeLine.properties 7500df9 > beeline/src/test/org/apache/hive/beeline/TestIncrementalRows.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/49782/diff/ > > > Testing > ------- > > * Unit Test added for `IncrementalRows` > * Tested locally > > > Thanks, > > Sahil Takiar > >
