----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ -----------------------------------------------------------
(Updated 2011-11-09 09:04:42.416457) Review request for hive, Siying Dong and Kevin Wilfong. Changes ------- I thought this patch is going to fix the bug in HIVE-2247, so I should put HIVE-2247 in the bugs field...It seems it is not like what I think. Summary (updated) ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562. https://issues.apache.org/jira/browse/HIVE-2562 Diffs ----- trunk/metastore/if/hive_metastore.thrift 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan