> On June 14, 2016, 6:31 p.m., Sergey Shelukhin wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 365 > > <https://reviews.apache.org/r/48159/diff/4-5/?file=1405612#file1405612line365> > > > > two nested synchornized-s on the same thing. > > Also nit: is it possible to have an object to sync on, rather than > > syncing on something with global visiblity > > Rajesh Balamohan wrote: > removed a nesting. Retaining sync on HMSHandler.class, as threadPool > itself is static.
I was more concerned with visibility, rather than static. I.e. when SomeClass does synchronized (this) it can backfire if someone decides to save on Object-s and instead does SomeClass foo; synchronized (foo). I guess with .class it's much less likely, so it should be ok - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48159/#review137561 ----------------------------------------------------------- On June 17, 2016, 5:56 a.m., Rajesh Balamohan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48159/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 5:56 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-13901 > https://issues.apache.org/jira/browse/HIVE-13901 > > > Repository: hive-git > > > Description > ------- > > Depending on FS, creating external tables & adding partitions can be > expensive (e.g msck which adds all partitions). > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cc95008 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c0827ea > > Diff: https://reviews.apache.org/r/48159/diff/ > > > Testing > ------- > > > Thanks, > > Rajesh Balamohan > >
