[ 
https://issues.apache.org/jira/browse/HIVE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146865#comment-13146865
 ] 

jirapos...@reviews.apache.org commented on HIVE-2247:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2783/
-----------------------------------------------------------

(Updated 2011-11-09 08:58:03.327969)


Review request for hive, Siying Dong and Kevin Wilfong.


Summary
-------

keep the old api alter_partition, and add the new api alter_rename_partition. 
In the server side, alter_partition calls alter_rename_partition with part_vals 
= null

Run the "ant test". Only load_fs.q fails, but after I revert the patch and run 
"ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q 
-Dtest.silent=false" it still fails. So I think it's not a bug introduced by my 
patch


This addresses bug HIVE-2247.
    https://issues.apache.org/jira/browse/HIVE-2247


Diffs
-----

  trunk/metastore/if/hive_metastore.thrift 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 
  
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 
1199598 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1199598 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
1199598 
  
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 
1199598 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
1199598 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1199598 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1199598 

Diff: https://reviews.apache.org/r/2783/diff


Testing
-------


Thanks,

Weiyan


                
> ALTER TABLE RENAME PARTITION
> ----------------------------
>
>                 Key: HIVE-2247
>                 URL: https://issues.apache.org/jira/browse/HIVE-2247
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Siying Dong
>            Assignee: Weiyan Wang
>         Attachments: HIVE-2247.10.patch.txt, HIVE-2247.11.patch.txt, 
> HIVE-2247.3.patch.txt, HIVE-2247.4.patch.txt, HIVE-2247.5.patch.txt, 
> HIVE-2247.6.patch.txt, HIVE-2247.7.patch.txt, HIVE-2247.8.patch.txt, 
> HIVE-2247.9.patch.txt, HIVE-2247.9.patch.txt
>
>
> We need a ALTER TABLE TABLE RENAME PARTITIONfunction that is similar t ALTER 
> TABLE RENAME.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to