----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48186/#review136104 -----------------------------------------------------------
Forgot to mentioned. This could use some unit tests. - Siddharth Seth On June 2, 2016, 8:55 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48186/ > ----------------------------------------------------------- > > (Updated June 2, 2016, 8:55 p.m.) > > > Review request for hive and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > llap-client/src/java/org/apache/hadoop/hive/llap/LlapInputSplit.java > 02aedfd > > llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java > 0edb1cd > llap-common/src/java/org/apache/hadoop/hive/llap/NotTezEventHelper.java > PRE-CREATION > llap-common/src/protobuf/LlapDaemonProtocol.proto 486ba0a > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java > 4306c22 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > d439c07 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTaskReporter.java > dc4482e > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java > 0d9882b > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java > 96d626a > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java > 54fc3af > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 140dbda > ql/src/java/org/apache/tez/dag/api/TaskSpecBuilder.java 6d31802 > > Diff: https://reviews.apache.org/r/48186/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
