----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review136073 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java (line 157) <https://reviews.apache.org/r/40867/#comment201047> Can you add a test with a join query as well? The join query should write the results in a new intermediate file on hdfs and it will be good to test that. jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 535) <https://reviews.apache.org/r/40867/#comment201054> This hardcodes the serde to LazySimpleSerde. There is work in https://issues.apache.org/jira/browse/HIVE-12049 where we write using a different serde in the final tasks. However, I'll create a follow-up jira for making this more generic. jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 551) <https://reviews.apache.org/r/40867/#comment201056> Nit: Usually an iterator implements https://docs.oracle.com/javase/7/docs/api/java/util/Iterator.html. jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 572) <https://reviews.apache.org/r/40867/#comment201055> Nit: getXXX methods are usually used to return something other than void. jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line 589) <https://reviews.apache.org/r/40867/#comment201058> This should be a private method. ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1976) <https://reviews.apache.org/r/40867/#comment201065> We can create a follow-up jira to handle this. ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1978) <https://reviews.apache.org/r/40867/#comment201067> Shouldn't the read happen independent of the file format? For example, the default format used to be TextFile until very recently and the user can as well choose to configure it that way. - Vaibhav Gumashta On May 18, 2016, 9:54 a.m., Takanobu Asanuma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40867/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 9:54 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > This is a WIP patch for HIVE-11527 > > * I added a new configuration whose name is > hive.server2.webhdfs.bypass.enabled. The default is false. When this value is > true, clients use the bypass. > > * I still have not considered security such as Kerberos and SSL at present. > > * I have not implement Statement#setFetchSize for bypass yet. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cbb3a72 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java > 84644d1 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 815ccfa > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java > 637e51a > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 92fdbca > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 38ccc78 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 3fecc5c > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java dff1815 > service-rpc/if/TCLIService.thrift 9879b1b > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 838bf17 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 5229230 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java > 31472c8 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java > 7101fa5 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java > 1aa3f94 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java > 14d50ed > service-rpc/src/gen/thrift/gen-php/Types.php 9ed7403 > service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 44e5462 > service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb b39ec1e > service/src/java/org/apache/hive/service/cli/CLIService.java ed52b4a > service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java bfd7135 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 0932884 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 2f18231 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 67e0e52 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 78ff388 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > a0015eb > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 5464e58 > > Diff: https://reviews.apache.org/r/40867/diff/ > > > Testing > ------- > > I have tested few simple queries and they worked well. But I think there are > some problems for some queries. I'm going to test more queries and fix bugs. > I'm also going to add unit tests. > > > Thanks, > > Takanobu Asanuma > >
