> On May 25, 2016, 6:59 p.m., Matt McCline wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDate.java, > > line 121 > > <https://reviews.apache.org/r/47792/diff/1/?file=1392824#file1392824line121> > > > > Nit -- Prasanth seems to think the new String form that takes the > > Charset enumeration instead of the charset String name "UTF-8" was better > > because it doesn't throw a UnsupportedEncodingException... > > > > So, perhaps you don't need the try/catch...
fixed > On May 25, 2016, 6:59 p.m., Matt McCline wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateAddScalarCol.java, > > line 98 > > <https://reviews.apache.org/r/47792/diff/1/?file=1392827#file1392827line98> > > > > Ditto earlier comment. fixed > On May 25, 2016, 6:59 p.m., Matt McCline wrote: > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorGenericDateExpressions.java, > > line 291 > > <https://reviews.apache.org/r/47792/diff/1/?file=1392834#file1392834line291> > > > > Nit -- I think the Charset enumeration version of getBytes is also > > available. fixed. I ended up changing all instances of this in the test, which ended up being in a lot of places. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47792/#review134806 ----------------------------------------------------------- On May 24, 2016, 8:33 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47792/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 8:33 p.m.) > > > Review request for hive, Ashutosh Chauhan and Matt McCline. > > > Bugs: HIVE-13248 > https://issues.apache.org/jira/browse/HIVE-13248 > > > Repository: hive-git > > > Description > ------- > > - Change date_add/date_sub/to_date functions to return Date type rather than > String (vectorized and non-vectorized path) > - Create date parser class for use by date_add/date_sub/to_date. > > > Diffs > ----- > > common/src/java/org/apache/hive/common/util/DateParser.java PRE-CREATION > common/src/test/org/apache/hive/common/util/TestDateParser.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDate.java > 98fdf4a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateAddColCol.java > 05dd93e > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateAddColScalar.java > 59ca61e > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateAddScalarCol.java > 2d0a28a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateLong.java > a58bfb5 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateString.java > e27ac6a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateTimestamp.java > cde0be4 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java > 8c376a0 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java > 92a72bf > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java > db0f4cd > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorGenericDateExpressions.java > 3f2b031 > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDate.java > c9f566d > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDateAdd.java > 08b9604 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDateSub.java > ab8d109 > ql/src/test/queries/clientpositive/union_offcbo.q 66d4bee > ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 13f6ab4 > ql/src/test/results/clientpositive/udf5.q.out 860ebcb > ql/src/test/results/clientpositive/udf9.q.out ddd4a5d > ql/src/test/results/clientpositive/union_offcbo.q.out 71c3bfc > ql/src/test/results/clientpositive/vectorized_date_funcs.q.out b8023e2 > > Diff: https://reviews.apache.org/r/47792/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
