> On May 18, 2016, 11:04 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java, > > line 102 > > <https://reviews.apache.org/r/47419/diff/1/?file=1384615#file1384615line102> > > > > For static partitions no need to specify part-spec ?
no need > On May 18, 2016, 11:04 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java, > > line 151 > > <https://reviews.apache.org/r/47419/diff/1/?file=1384615#file1384615line151> > > > > Will this trigger new calls to metastore to collect metadata ? sure, we should cache > On May 18, 2016, 11:04 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java, > > line 157 > > <https://reviews.apache.org/r/47419/diff/1/?file=1384615#file1384615line157> > > > > Might make sense to throw an exception if values().size() > 1 agree > On May 18, 2016, 11:04 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java, lines 267-277 > > <https://reviews.apache.org/r/47419/diff/1/?file=1384620#file1384620line267> > > > > Wanna move this utility BFS search method in some utils class. Might be > > useful for other purposes as well. agree - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47419/#review133828 ----------------------------------------------------------- On May 16, 2016, 6:11 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47419/ > ----------------------------------------------------------- > > (Updated May 16, 2016, 6:11 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13566 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 541af57 > itests/src/test/resources/testconfiguration.properties c891d40 > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java d8ac6ae > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > d213731 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java > 9fbbd4c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 02c5a89 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 3b6cbce > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 96ef20d > ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 3a226e7 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7162c08 > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 4049f40 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java > 7433263 > ql/src/test/queries/clientpositive/autoColumnStats_1.q PRE-CREATION > ql/src/test/queries/clientpositive/autoColumnStats_2.q PRE-CREATION > ql/src/test/queries/clientpositive/autoColumnStats_3.q PRE-CREATION > ql/src/test/queries/clientpositive/autoColumnStats_4.q PRE-CREATION > ql/src/test/queries/clientpositive/autoColumnStats_5.q PRE-CREATION > ql/src/test/queries/clientpositive/autoColumnStats_6.q PRE-CREATION > ql/src/test/queries/clientpositive/autoColumnStats_7.q PRE-CREATION > ql/src/test/queries/clientpositive/autoColumnStats_8.q PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_1.q.out PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_2.q.out PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_3.q.out PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_4.q.out PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_5.q.out PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_6.q.out PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_7.q.out PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_8.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/autoColumnStats_2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/47419/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
