----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47353/#review133447 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java (lines 694 - 695) <https://reviews.apache.org/r/47353/#comment197875> Similar to openTransaction, commitTransaction will not do the real commit until openTrasactionCalls reaches 0. So deleteTableColumnStatistics() or updateTableColumnStatistics() will not be committed actually, until line 244 in which all the operations will be committed. Here is the commitTransaction() logic. openTrasactionCalls--; debugLog("Commit transaction: count = " + openTrasactionCalls + ", isactive "+ currentTransaction.isActive()); if ((openTrasactionCalls == 0) && currentTransaction.isActive()) { transactionStatus = TXN_STATUS.COMMITED; currentTransaction.commit(); } - Aihua Xu On May 13, 2016, 7:17 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47353/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 7:17 p.m.) > > > Review request for hive and Chaoyu Tang. > > > Repository: hive-git > > > Description > ------- > > HIVE-13616: Investigate renaming a table without invalidating the column stats > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 0652b9db1a4224262611ff9258e871647442cfeb > ql/src/test/queries/clientpositive/rename_table_update_column_stats.q > PRE-CREATION > ql/src/test/results/clientpositive/rename_table_update_column_stats.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/47353/diff/ > > > Testing > ------- > > Tests have been run and the failed tests don't seem to be related. > > To carry over the column stats during renaming the table, the patch > 1. Save affected column stats > 2. Rename the table > 3. Write the saved column stats for the new table. > > In this order, column stats will find the foreign key when writing in 3). > > > Thanks, > > Aihua Xu > >
