> On May 12, 2016, 5:48 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 3074 > > <https://reviews.apache.org/r/47242/diff/1/?file=1379752#file1379752line3074> > > > > It could have been. Feels cleaner to me as non-static. Just a matter of > > style. Is there any advantage of keeping it static?
Just thought the method is protected and may be accessed in sub-classes. If that's not a concern, I'm OK with non-static. - Rui ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47242/#review132822 ----------------------------------------------------------- On May 11, 2016, 4:36 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47242/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 4:36 p.m.) > > > Review request for hive and Rui Li. > > > Bugs: HIVE-13726 > https://issues.apache.org/jira/browse/HIVE-13726 > > > Repository: hive-git > > > Description > ------- > > For insert overwrite significant amount might be spent in deleting existing > files. This patch parallelizes this task. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 71c9188 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java dd14124 > > Diff: https://reviews.apache.org/r/47242/diff/ > > > Testing > ------- > > existing regression tests. No change in functionality. > > > Thanks, > > Ashutosh Chauhan > >
