----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47051/#review131980 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (lines 1833 - 1835) <https://reviews.apache.org/r/47051/#comment196021> I think better comment could be something like following: // We need to compare partition name with requested name since some DBs (like MySQL, Derby) considers 'a' = 'a ' whereas others like (Postgres, Oracle) doesn't exhibit this problem. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 1837) <https://reviews.apache.org/r/47051/#comment196023> We should throw exception if mparts.size() > 1 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 1838) <https://reviews.apache.org/r/47051/#comment196022> Does this need equalsIgnoreCase() ? - Ashutosh Chauhan On May 6, 2016, 1:38 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47051/ > ----------------------------------------------------------- > > (Updated May 6, 2016, 1:38 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13618 > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 88381aa > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 5c49be9 > > ql/src/test/queries/clientnegative/partition_column_names_with_leading_and_trailing_spaces.q > PRE-CREATION > > ql/src/test/queries/clientpositive/partition_column_names_with_leading_and_trailing_spaces.q > PRE-CREATION > > ql/src/test/results/clientnegative/partition_column_names_with_leading_and_trailing_spaces.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/tez/partition_column_names_with_leading_and_trailing_spaces.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/47051/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
