----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45911/#review131659 -----------------------------------------------------------
Patch looks good. Checked golden files, looks good. ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java (line 815) <https://reviews.apache.org/r/45911/#comment195696> We need similiar logic for alter Table add partition. - Ashutosh Chauhan On May 3, 2016, 8:40 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45911/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 8:40 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13341: Stats state is not captured correctly: differentiate load table > and create table > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 41d150c > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java > c046708 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 76220f4 > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 54592cc > ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 87a7667 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 500c7ed > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 2dc4e11 > ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 667d5c2 > ql/src/test/queries/clientpositive/insert_values_orig_table_use_metadata.q > PRE-CREATION > ql/src/test/queries/clientpositive/stats20.q 59701bd > ql/src/test/results/clientpositive/alter_file_format.q.out 5d83b23 > ql/src/test/results/clientpositive/alter_skewed_table.q.out a1caa99 > ql/src/test/results/clientpositive/alter_table_not_sorted.q.out 6e1ec59 > ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out 0902556 > ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 81de2b0 > ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 26a11a7 > ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out 78cd03d > ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out 7ddf6b3 > ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 5b68da2 > ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out 07bcb89 > ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out d12c1ca > ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 23a3685 > ql/src/test/results/clientpositive/binary_output_format.q.out 608d475 > ql/src/test/results/clientpositive/bucket1.q.out 96b8d4e > ql/src/test/results/clientpositive/bucket2.q.out b5572fd > ql/src/test/results/clientpositive/bucket4.q.out c4baf72 > ql/src/test/results/clientpositive/bucket5.q.out dee79f9 > ql/src/test/results/clientpositive/bucket_many.q.out 90d9fb8 > ql/src/test/results/clientpositive/bucket_map_join_1.q.out 49bf2ca > ql/src/test/results/clientpositive/bucket_map_join_2.q.out 9ec7033 > ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out 19937cb > ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out 90528be > ql/src/test/results/clientpositive/bucket_map_join_spark3.q.out aede979 > ql/src/test/results/clientpositive/bucketcontext_1.q.out d1b7744 > ql/src/test/results/clientpositive/bucketcontext_2.q.out 60c021c > ql/src/test/results/clientpositive/bucketcontext_3.q.out 12eaddf > ql/src/test/results/clientpositive/bucketcontext_4.q.out 2573564 > ql/src/test/results/clientpositive/bucketcontext_5.q.out e1c6a80 > ql/src/test/results/clientpositive/bucketcontext_6.q.out 9deb64d > ql/src/test/results/clientpositive/bucketcontext_7.q.out 621844e > ql/src/test/results/clientpositive/bucketcontext_8.q.out 7f3e50a > ql/src/test/results/clientpositive/bucketmapjoin1.q.out 9956fa7 > ql/src/test/results/clientpositive/bucketmapjoin10.q.out fcdbb09 > ql/src/test/results/clientpositive/bucketmapjoin11.q.out 968066a > ql/src/test/results/clientpositive/bucketmapjoin12.q.out 9017871 > ql/src/test/results/clientpositive/bucketmapjoin2.q.out f2efb95 > ql/src/test/results/clientpositive/bucketmapjoin3.q.out 5659983 > ql/src/test/results/clientpositive/bucketmapjoin4.q.out 5794d47 > ql/src/test/results/clientpositive/bucketmapjoin5.q.out 1bcb382 > ql/src/test/results/clientpositive/bucketmapjoin7.q.out 76b13f3 > ql/src/test/results/clientpositive/bucketmapjoin8.q.out 097eaad > ql/src/test/results/clientpositive/bucketmapjoin9.q.out 144d86d > ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out d108575 > ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out 9c6a226 > ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out 3078854 > > ql/src/test/results/clientpositive/columnStatsUpdateForStatsOptimizer_1.q.out > 8c9664d > > ql/src/test/results/clientpositive/column_names_with_leading_and_trailing_spaces.q.out > 46c285e > ql/src/test/results/clientpositive/columnstats_partlvl.q.out 4edf39a > ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 669807d > ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out > c4f51a3 > ql/src/test/results/clientpositive/create_like.q.out 9241b68 > ql/src/test/results/clientpositive/create_like_view.q.out e2dc2c4 > ql/src/test/results/clientpositive/create_skewed_table1.q.out 415bb77 > ql/src/test/results/clientpositive/database_location.q.out 797177d > ql/src/test/results/clientpositive/default_file_format.q.out 3d5c20f > ql/src/test/results/clientpositive/describe_comment_indent.q.out 3e0f45e > ql/src/test/results/clientpositive/describe_comment_nonascii.q.out df0b65e > ql/src/test/results/clientpositive/disable_merge_for_bucketing.q.out > c4dbf17 > ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 1028c26 > ql/src/test/results/clientpositive/groupby_map_ppr.q.out 3d07b0d > ql/src/test/results/clientpositive/groupby_map_ppr_multi_distinct.q.out > 6689225 > ql/src/test/results/clientpositive/groupby_ppr.q.out 62fffbe > ql/src/test/results/clientpositive/groupby_ppr_multi_distinct.q.out 2408056 > ql/src/test/results/clientpositive/groupby_sort_1_23.q.out a6e15ba > ql/src/test/results/clientpositive/groupby_sort_6.q.out f523085 > ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 38b24a4 > ql/src/test/results/clientpositive/input_part1.q.out 2abaa3b > ql/src/test/results/clientpositive/input_part2.q.out 2ce071c > > ql/src/test/results/clientpositive/insert_values_orig_table_use_metadata.q.out > PRE-CREATION > ql/src/test/results/clientpositive/join17.q.out 39c49a5 > ql/src/test/results/clientpositive/join26.q.out 0fdc403 > ql/src/test/results/clientpositive/join32.q.out aad5463 > ql/src/test/results/clientpositive/join32_lessSize.q.out a94b951 > ql/src/test/results/clientpositive/join33.q.out aad5463 > ql/src/test/results/clientpositive/join34.q.out 74fac5c > ql/src/test/results/clientpositive/join35.q.out 6fe9cae > ql/src/test/results/clientpositive/join9.q.out f41d153 > ql/src/test/results/clientpositive/join_map_ppr.q.out e720e65 > ql/src/test/results/clientpositive/list_bucket_dml_14.q.out c063dc1 > ql/src/test/results/clientpositive/list_bucket_dml_8.q.java1.7.out d40a693 > ql/src/test/results/clientpositive/mapjoin_memcheck.q.out 8f5492f > ql/src/test/results/clientpositive/nullformat.q.out af91470 > ql/src/test/results/clientpositive/orc_create.q.out 3013fda > ql/src/test/results/clientpositive/orc_llap.q.out 6fc73b7 > ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 7b361b7 > ql/src/test/results/clientpositive/parquet_array_null_element.q.out 387f01e > ql/src/test/results/clientpositive/parquet_create.q.out c6d33ff > ql/src/test/results/clientpositive/parquet_mixed_partition_formats.q.out > d6affd6 > ql/src/test/results/clientpositive/parquet_serde.q.out c1e594a > ql/src/test/results/clientpositive/pcr.q.out b53226e > ql/src/test/results/clientpositive/rand_partitionpruner2.q.out d88c53d > ql/src/test/results/clientpositive/rcfile_default_format.q.out c961231 > ql/src/test/results/clientpositive/reduce_deduplicate.q.out 379f884 > ql/src/test/results/clientpositive/sample1.q.out e188902 > ql/src/test/results/clientpositive/sample2.q.out 9653c41 > ql/src/test/results/clientpositive/sample4.q.out a9730b1 > ql/src/test/results/clientpositive/sample5.q.out d5ff403 > ql/src/test/results/clientpositive/sample6.q.out ea71ad6 > ql/src/test/results/clientpositive/sample7.q.out 94618e5 > ql/src/test/results/clientpositive/show_create_table_alter.q.out 32819ea > ql/src/test/results/clientpositive/show_create_table_db_table.q.out 495f4b5 > ql/src/test/results/clientpositive/show_create_table_serde.q.out 2350d98 > ql/src/test/results/clientpositive/show_tblproperties.q.out 63bbe6d > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out > 76ea0a8 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out > 5564ceb > ql/src/test/results/clientpositive/spark/stats20.q.out d7e52b4 > ql/src/test/results/clientpositive/stats0.q.out 90a9a70 > ql/src/test/results/clientpositive/stats1.q.out 72c53e3 > ql/src/test/results/clientpositive/stats11.q.out 8ca5b27 > ql/src/test/results/clientpositive/stats18.q.out 6971e44 > ql/src/test/results/clientpositive/stats20.q.out d7e52b4 > ql/src/test/results/clientpositive/stats3.q.out 4dbda94 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_1.q.out 892539d > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_11.q.out 954fd96 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_12.q.out 578880d > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_2.q.out c283738 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_3.q.out 351fd20 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_4.q.out 2d9cdf8 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_5.q.out 8bc203a > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_7.q.out 18fc95c > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_8.q.out 9a1010c > ql/src/test/results/clientpositive/tez/bucket2.q.out e9432a8 > ql/src/test/results/clientpositive/tez/bucket4.q.out a0f1177 > > ql/src/test/results/clientpositive/tez/column_names_with_leading_and_trailing_spaces.q.out > 46c285e > ql/src/test/results/clientpositive/tez/disable_merge_for_bucketing.q.out > bb62e1f > ql/src/test/results/clientpositive/tez/explainuser_1.q.out bdb8830 > ql/src/test/results/clientpositive/tez/sample1.q.out 009969e > ql/src/test/results/clientpositive/tez/tez_join_result_complex.q.out > 3e3b08c > ql/src/test/results/clientpositive/tez/vectorized_ptf.q.out 1365626 > ql/src/test/results/clientpositive/truncate_column.q.out adbddfa > ql/src/test/results/clientpositive/truncate_column_list_bucket.q.out > 39ffc6c > ql/src/test/results/clientpositive/unicode_notation.q.out 52da674 > ql/src/test/results/clientpositive/unset_table_view_property.q.out 8bbb9fe > ql/src/test/results/clientpositive/vectorized_ptf.q.out fc4351d > > Diff: https://reviews.apache.org/r/45911/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
