----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46755/#review130966 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java (line 2408) <https://reviews.apache.org/r/46755/#comment194890> can you also add a test where query timeout is not met ? ie set large value of query timeout and run a quick query ('show tables' ?), and make sure it completes without errors ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1729) <https://reviews.apache.org/r/46755/#comment194874> s/of/if/ service-rpc/if/TCLIService.thrift (line 705) <https://reviews.apache.org/r/46755/#comment194881> I was debating with myself if we should use i32 to match with jdbc api spec. However, looks like the ODBC spec uses 64bit here. SQLSetStmtAttr in odbc sets SQL_ATTR_QUERY_TIMEOUT using SQLULEN, with is 64 bit. service/src/java/org/apache/hive/service/cli/OperationState.java (line 36) <https://reviews.apache.org/r/46755/#comment194883> isnt timed out state a terminal state ? service/src/java/org/apache/hive/service/cli/operation/OperationManager.java (line 255) <https://reviews.apache.org/r/46755/#comment194887> should we check for if(ipState.isTerminal() ) instead ? I don't think UNKOWN needs to be in this list. We never set anything to UNKNOWN . - Thejas Nair On April 27, 2016, 11:14 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46755/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 11:14 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-4924 > https://issues.apache.org/jira/browse/HIVE-4924 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-4924 > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > 965627f > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java > 4d763d2 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 3cc6b74 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java dad43fb > ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java 0234fd9 > service-rpc/if/TCLIService.thrift 92bcf77 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 9f937ca > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 66f5e8c > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java > 2eb4d09 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationState.java > 3fa49b0 > service-rpc/src/gen/thrift/gen-php/Types.php 7f1f99f > service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 3bb20b8 > service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 7208bae > service/src/java/org/apache/hive/service/cli/CLIService.java 4a83e38 > service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java > 79e0024 > service/src/java/org/apache/hive/service/cli/ICLIService.java e4aef96 > service/src/java/org/apache/hive/service/cli/OperationState.java 6a67a1d > > service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java > b3d9b52 > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > f18dc67 > > service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java > 77228fa > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 63b1a48 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 52e4b4d > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 01dd48c > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 9ea643b > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 0cfec7a > > service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java > b2e0e9e > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 6ede1d7 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java > 098aea6 > > service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java > 1740079 > > service/src/test/org/apache/hive/service/cli/thrift/ThriftCliServiceTestWithCookie.java > a1ef1fc > > Diff: https://reviews.apache.org/r/46755/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
