----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46020/#review130453 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2998) <https://reviews.apache.org/r/46020/#comment194190> Is this ctrl+A delimiter? This is only a default value, user can choose any other delimiter. We should get this from properties of Table. - Ashutosh Chauhan On April 25, 2016, 5:16 p.m., Vladislav Pavlenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46020/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 5:16 p.m.) > > > Review request for hive. > > > Bugs: HIVE-10176 > https://issues.apache.org/jira/browse/HIVE-10176 > > > Repository: hive-git > > > Description > ------- > > When inserting values in to tables with TBLPROPERTIES > ("skip.header.line.count"="1") the first value listed is also skipped1. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java a5489a9 > ql/src/java/org/apache/hadoop/hive/ql/exec/FooterBuffer.java 6a407af > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 54592cc > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java ab0635e > ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java > 4a05a62 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce > ql/src/test/queries/clientnegative/file_with_header_footer_negative.q > 1f63d94 > ql/src/test/queries/clientpositive/file_with_header_footer.q 8913e54 > ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out > 1794ae6 > ql/src/test/results/clientpositive/file_with_header_footer.q.out ca3dadb > ql/src/test/results/clientpositive/skiphf_aggr.q.out aeb4b1b > > Diff: https://reviews.apache.org/r/46020/diff/ > > > Testing > ------- > > All the 2 failures are not related: > org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3 > org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery. > > UPD: Now I don't create tmp file. Add methow that upload file in hdfs > directly. > > > Thanks, > > Vladislav Pavlenko > >
