> On April 23, 2016, 5:45 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/create_with_constraints.q, line 2 > > <https://reviews.apache.org/r/45274/diff/4/?file=1358471#file1358471line2> > > > > Please add describe statement for all tables. They should list all > > constraints of table. > > Hari Sankar Sivarama Subramaniyan wrote: > This is not trivial with the current implementation. The constraints are > a separate entity altogether and not part of the Table. I need to make some > changes to DDLTask.describeTable() to support this(fetch primarykeys, > foreignkeys for the table and update the metadataformatter implementation to > show this information when in extended mode). Would be good to get the > current changes in and do this in a follow-up jira?
Ok.. lets do this in a follow-up. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/#review130263 ----------------------------------------------------------- On April 23, 2016, 8:20 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45274/ > ----------------------------------------------------------- > > (Updated April 23, 2016, 8:20 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > Support primary keys/foreign keys constraint as part of create table command > in Hive > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ae6f084 > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 19342a8 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g dd997f0 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a192fa7 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 549d24f > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 005b53f > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b > ql/src/test/queries/clientnegative/create_with_constraints_duplicate_name.q > PRE-CREATION > ql/src/test/queries/clientnegative/create_with_constraints_enable.q > PRE-CREATION > ql/src/test/queries/clientnegative/create_with_constraints_validate.q > PRE-CREATION > ql/src/test/queries/clientpositive/create_with_constraints.q PRE-CREATION > > ql/src/test/results/clientnegative/create_with_constraints_duplicate_name.q.out > PRE-CREATION > ql/src/test/results/clientnegative/create_with_constraints_enable.q.out > PRE-CREATION > ql/src/test/results/clientnegative/create_with_constraints_validate.q.out > PRE-CREATION > ql/src/test/results/clientpositive/create_with_constraints.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/45274/diff/ > > > Testing > ------- > > Local testing done > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
