----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/#review129030 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3267) <https://reviews.apache.org/r/45406/#comment192495> Instead of making this check, we should just try to persist the row in constraint table, it will fail in case there is a duplicate name, since its a part of primary key, in which case we pick another name. metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraintPK.java (line 7) <https://reviews.apache.org/r/45406/#comment192496> I don't see this class getting used anywhere. In jdo mapping its seems you are using inner class PK which is defined in MConstraint. Do we need both? - Ashutosh Chauhan On April 14, 2016, 10:44 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45406/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 10:44 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > Metastore Changes : API calls for retrieving primary keys and foreign keys > information > > > Diffs > ----- > > metastore/if/hive_metastore.thrift 6a55962 > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION > metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 > metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION > metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 > metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 > metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION > metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 > metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 > metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION > metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be > metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 > metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION > metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 > metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql > 6172407 > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysRequest.java > PRE-CREATION > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysResponse.java > PRE-CREATION > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysRequest.java > PRE-CREATION > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysResponse.java > PRE-CREATION > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLForeignKey.java > PRE-CREATION > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLPrimaryKey.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c9fadad > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 64a26ac > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 39cf927 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 06e9f78 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ac293b9 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java > a73dbeb > metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java > PRE-CREATION > > metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraintPK.java > PRE-CREATION > metastore/src/model/package.jdo 7385a13 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 94ca835 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > b108f95 > > Diff: https://reviews.apache.org/r/45406/diff/ > > > Testing > ------- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
