[
https://issues.apache.org/jira/browse/HIVE-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145677#comment-13145677
]
jirapos...@reviews.apache.org commented on HIVE-2545:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2676/#review3078
-----------------------------------------------------------
Ship it!
LGTM
- Ning
On 2011-11-02 20:18:42, Kevin Wilfong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2676/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-02 20:18:42)
bq.
bq.
bq. Review request for hive, Patrick Hunt, Carl Steinbach, Yongqiang He, Ning
Zhang, Paul Yang, and namit jain.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The metastore uses the default hive-log4j.properties only if the
log4j.configuration system property hasn't already been set.
bq.
bq.
bq. This addresses bug HIVE-2545.
bq. https://issues.apache.org/jira/browse/HIVE-2545
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1196155
bq.
bq. Diff: https://reviews.apache.org/r/2676/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Verified that this allows the properties file specified in
log4j.configuration is used if it is specified.
bq.
bq. Verified that the default hive-log4j.properties file is used if
log4j.configuration is not specified.
bq.
bq. Verified if the metastore is started via
bq. ./hive --service metastore
bq. in the bin directory, the default properties file is used. (I assume this
is the use case the default was added for from looking at the diff for
HIVE-2139)
bq.
bq.
bq. Thanks,
bq.
bq. Kevin
bq.
bq.
> Make metastore log4j configuration file configurable again.
> -----------------------------------------------------------
>
> Key: HIVE-2545
> URL: https://issues.apache.org/jira/browse/HIVE-2545
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.9.0
>
> Attachments: HIVE-2545.1.patch.txt
>
>
> The patch for https://issues.apache.org/jira/browse/HIVE-2139 hard coded the
> metastore to use hive-log4j.properties as the log4j configuration file.
> Previously this was configurable through the log4j.configuration variable
> passed into Java. It should be configurable again, though not necessarily
> through the same means.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
