> On April 4, 2016, 6:19 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java, > > line 715 > > <https://reviews.apache.org/r/45602/diff/1/?file=1322596#file1322596line715> > > > > Whoa, the vectorized timestamp cast was always incorrect?
yup. > On April 4, 2016, 6:19 p.m., Jason Dere wrote: > > ql/src/test/results/clientpositive/cast_on_constant.q.out, line 25 > > <https://reviews.apache.org/r/45602/diff/1/?file=1322600#file1322600line25> > > > > These predicates don't actually show the types used in the comparison > > .. if it was doing string comparison would the constant value be in quotes? Yup.. On master.. this expression will be (UDFToString(ts_field) = '2016-01-23 00:00:00') - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45602/#review126882 ----------------------------------------------------------- On April 1, 2016, 8:49 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45602/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 8:49 p.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-13381 > https://issues.apache.org/jira/browse/HIVE-13381 > > > Repository: hive-git > > > Description > ------- > > Comparisons between timestamp/date & string group should happen in ts/date > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 56b96b4 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 1eb960d > ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java > 6a83c32 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > e4c7529 > ql/src/test/queries/clientpositive/cast_on_constant.q PRE-CREATION > ql/src/test/results/clientpositive/cast_on_constant.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/45602/diff/ > > > Testing > ------- > > New test & existing regression suite. > > > Thanks, > > Ashutosh Chauhan > >
