----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45137/#review125688 -----------------------------------------------------------
service/src/java/org/apache/hive/service/server/HiveServer2.java (line 455) <https://reviews.apache.org/r/45137/#comment188559> Looks like addServerInstanceToZooKeeper would get called twice on start of HS2 from commandline. Should we remove that from startHiveServer2 method ? - Thejas Nair On March 28, 2016, 11:47 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45137/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 11:47 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-13326 > https://issues.apache.org/jira/browse/HIVE-13326 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-13326 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b8870f2 > itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > 751d8ea > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithLocalClusterSpark.java > f649fc2 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java > bcd65a9 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestMultiSessionsHS2WithLocalClusterSpark.java > 0c3479d > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestServiceDiscoveryWithMiniHS2.java > PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java > 0bb3c0a > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcMetadataApiAuth.java > 19b311d > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcWithSQLAuthorization.java > dacde45 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 > service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 > > Diff: https://reviews.apache.org/r/45137/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >