[
https://issues.apache.org/jira/browse/HIVE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144875#comment-13144875
]
Phabricator commented on HIVE-2532:
-----------------------------------
ikabiljo has commented on the revision "HIVE-2532 [jira] Evaluation of
non-deterministic/stateful UDFs should not be skipped even if constant oi is
returned.".
Java code looks good, not sure what are .q and .q.out files, so will leave to
others to accept :)
Just a small inline comment.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrue.java:60-61
why don't convert to javaBooleanObjectInspector, usage is easier?
REVISION DETAIL
https://reviews.facebook.net/D273
> Evaluation of non-deterministic/stateful UDFs should not be skipped even if
> constant oi is returned.
> ----------------------------------------------------------------------------------------------------
>
> Key: HIVE-2532
> URL: https://issues.apache.org/jira/browse/HIVE-2532
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D273.1.patch
>
>
> Even if constant oi is returned, these may have stateful/side-effect behavior
> and hence need to be called each cycle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
