> On March 2, 2016, 5:53 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java, > > line 178 > > <https://reviews.apache.org/r/18182/diff/3/?file=1275798#file1275798line178> > > > > I assume you only allow F to be a constant string. If so, this > > evaluation can happen at compile time in initialize(). You can obtain > > value via ConstantStringOI.
Yes. Makes sense. Updated. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18182/#review121679 ----------------------------------------------------------- On March 3, 2016, 6:19 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18182/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 6:19 a.m.) > > > Review request for hive, Ashutosh Chauhan, Alan Gates, and Navis Ryu. > > > Bugs: HIVE-5370 > https://issues.apache.org/jira/browse/HIVE-5370 > > > Repository: hive-git > > > Description > ------- > > Added the format as optional argument. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java > 71ca8f2 > ql/src/test/queries/clientnegative/udf_format_number_wrong6.q e5b11b9 > ql/src/test/queries/clientpositive/udf_format_number.q 28f087d > ql/src/test/results/clientnegative/udf_format_number_wrong1.q.out c3cb800 > ql/src/test/results/clientnegative/udf_format_number_wrong2.q.out 1fe8a7c > ql/src/test/results/clientnegative/udf_format_number_wrong4.q.out 3953ef1 > ql/src/test/results/clientnegative/udf_format_number_wrong6.q.out d51991f > ql/src/test/results/clientpositive/udf_format_number.q.out 4a2c80d > > Diff: https://reviews.apache.org/r/18182/diff/ > > > Testing > ------- > > Unit tested > > > Thanks, > > Amareshwari Sriramadasu > >
