-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44146/
-----------------------------------------------------------
(Updated Feb. 28, 2016, 10:19 p.m.)
Review request for hive.
Bugs: HIVE-13179
https://issues.apache.org/jira/browse/HIVE-13179
Repository: hive-git
Description
-------
Right now if I want to create an ldap auth provider, I have to create a
hive-site.xml, set endpoints and other relevant properties there, then
instantiate `LdapAuthenticationProviderImpl`, since inside the constructor, a
new HiveConf is constructed.
A better and more reusable design would be to ask for the conf in the
constructor itself. That will allow an external user to create a HiveConf, set
all relevant properties and instantiate `LdapAuthenticationProviderImpl` with
that conf.
Diffs (updated)
-----
service/src/java/org/apache/hive/service/auth/AuthenticationProviderFactory.java
4b95503
service/src/java/org/apache/hive/service/auth/CustomAuthenticationProviderImpl.java
3dc0aa8
service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java
1d4aba2
service/src/java/org/apache/hive/service/auth/PamAuthenticationProviderImpl.java
fd58081
service/src/test/org/apache/hive/service/auth/TestLdapAtnProviderWithMiniDS.java
e5cee37
service/src/test/org/apache/hive/service/auth/TestLdapAuthenticationProviderImpl.java
5e91a0e
Diff: https://reviews.apache.org/r/44146/diff/
Testing
-------
Thanks,
Rajat Khandelwal
