----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43834/#review120371 -----------------------------------------------------------
It will also be good to add true junit tests for this. You may look at TestHiveAuthorizerCheckInvocation for pattern. ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java (line 403) <https://reviews.apache.org/r/43834/#comment181831> Instead of repeating all the logic here, shall we call super() here? ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java (line 50) <https://reviews.apache.org/r/43834/#comment181832> better name: viewAliasToViewSchema? ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (lines 10439 - 10449) <https://reviews.apache.org/r/43834/#comment181834> Do we really need to invoke CP here? When CP gets invoked later on in optimize phase, it will populate column access info correctly, right? ql/src/test/queries/clientnegative/authorization_view_1.q (line 12) <https://reviews.apache.org/r/43834/#comment181807> Add: grant select(key) on v to user hive_test_user; Test should still fail, since hive_test_user doesnt have select privs for value. ql/src/test/queries/clientnegative/authorization_view_2.q (line 11) <https://reviews.apache.org/r/43834/#comment181808> Change user to hive_test_user for both statements. ql/src/test/queries/clientnegative/authorization_view_disable_cbo_1.q (line 12) <https://reviews.apache.org/r/43834/#comment181809> Similar comment as above. ql/src/test/queries/clientnegative/authorization_view_disable_cbo_3.q (line 11) <https://reviews.apache.org/r/43834/#comment181811> User name: hive_test_user - Ashutosh Chauhan On Feb. 22, 2016, 3:24 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43834/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 3:24 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13095 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 10bd97b > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java > 78bce23 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java > 18145ae > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 809affb > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 642c227 > ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java f04b493 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8a06582 > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java fc555ca > ql/src/test/queries/clientnegative/authorization_view_1.q PRE-CREATION > ql/src/test/queries/clientnegative/authorization_view_2.q PRE-CREATION > ql/src/test/queries/clientnegative/authorization_view_disable_cbo_1.q > PRE-CREATION > ql/src/test/queries/clientnegative/authorization_view_disable_cbo_2.q > PRE-CREATION > ql/src/test/queries/clientnegative/authorization_view_disable_cbo_3.q > PRE-CREATION > ql/src/test/queries/clientpositive/authorization_view_1.q PRE-CREATION > ql/src/test/queries/clientpositive/authorization_view_disable_cbo_1.q > PRE-CREATION > ql/src/test/results/clientnegative/authorization_view_1.q.out PRE-CREATION > ql/src/test/results/clientnegative/authorization_view_2.q.out PRE-CREATION > ql/src/test/results/clientnegative/authorization_view_disable_cbo_1.q.out > PRE-CREATION > ql/src/test/results/clientnegative/authorization_view_disable_cbo_2.q.out > PRE-CREATION > ql/src/test/results/clientnegative/authorization_view_disable_cbo_3.q.out > PRE-CREATION > ql/src/test/results/clientpositive/authorization_view_1.q.out PRE-CREATION > ql/src/test/results/clientpositive/authorization_view_disable_cbo_1.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/43834/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
