----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ -----------------------------------------------------------
(Updated 2月 3, 2016, 9:32 a.m.) Review request for hive. Changes ------- Sorry, I forgot to regenerate thrift files in the before patch. Please ignore that. About this patch: I changed typeName from required to optional in thrift API. If this is null, when new client sends the request to the old server, clients use old path without bypass. I regenerated thrift files. I merged latest master branch. Repository: hive-git Description ------- This is a WIP patch for HIVE-11527 * I added a new configuration whose name is hive.server2.webhdfs.bypass.enabled. The default is false. When this value is true, clients use the bypass. * I still have not considered security such as Kerberos and SSL at present. * I have not implement Statement#setFetchSize for bypass yet. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6678de6 jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4c89812 ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 0b0c336 service-rpc/if/TCLIService.thrift 0aa9d13 service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 5364293 service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b7 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java 31472c8 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java 7101fa5 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java 14d50ed service-rpc/src/gen/thrift/gen-php/Types.php 76805df service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f5 service-rpc/src/gen/thrift/gen-py/__init__.py PRE-CREATION service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec4 service/src/gen/thrift/gen-cpp/ThriftHive.h PRE-CREATION service/src/gen/thrift/gen-cpp/ThriftHive.cpp PRE-CREATION service/src/gen/thrift/gen-cpp/ThriftHive_server.skeleton.cpp PRE-CREATION service/src/gen/thrift/gen-cpp/hive_service_constants.h PRE-CREATION service/src/gen/thrift/gen-cpp/hive_service_constants.cpp PRE-CREATION service/src/gen/thrift/gen-cpp/hive_service_types.h PRE-CREATION service/src/gen/thrift/gen-cpp/hive_service_types.cpp PRE-CREATION service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java PRE-CREATION service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java PRE-CREATION service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/JobTrackerState.java PRE-CREATION service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java PRE-CREATION service/src/gen/thrift/gen-php/ThriftHive.php PRE-CREATION service/src/gen/thrift/gen-php/Types.php PRE-CREATION service/src/gen/thrift/gen-py/__init__.py PRE-CREATION service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote PRE-CREATION service/src/gen/thrift/gen-py/hive_service/ThriftHive.py PRE-CREATION service/src/gen/thrift/gen-py/hive_service/__init__.py PRE-CREATION service/src/gen/thrift/gen-py/hive_service/constants.py PRE-CREATION service/src/gen/thrift/gen-py/hive_service/ttypes.py PRE-CREATION service/src/gen/thrift/gen-rb/hive_service_constants.rb PRE-CREATION service/src/gen/thrift/gen-rb/hive_service_types.rb PRE-CREATION service/src/gen/thrift/gen-rb/thrift_hive.rb PRE-CREATION service/src/java/org/apache/hive/service/cli/CLIService.java cc6e138 service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06 service/src/java/org/apache/hive/service/cli/operation/Operation.java 0c263cf service/src/java/org/apache/hive/service/cli/operation/OperationManager.java f1ce6f6 service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 01b1d3d service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 6aee80c service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java d9a9e3b Diff: https://reviews.apache.org/r/40867/diff/ Testing ------- I have tested few simple queries and they worked well. But I think there are some problems for some queries. I'm going to test more queries and fix bugs. I'm also going to add unit tests. Thanks, Takanobu Asanuma
