> On Jan. 20, 2016, 10:45 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line > > 11188 > > <https://reviews.apache.org/r/42322/diff/1/?file=1197204#file1197204line11188> > > > > The patch looks good to me +1. Just one small thing and it is up to you > > to modify it or not. Although Stack works here, with the same time/space > > complexity, I would prefer a simple Queue. First dequeue the head, then > > enqueue the children from left to right. Right now a Stack is used and the > > children are pushed right to left...
If we used a Queue, the traversal would be different: it would be level by level (similar to BFS). Observe that currently it is similar to DFS. Could you +1 in the JIRA issue? Thanks! - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42322/#review115506 ----------------------------------------------------------- On Jan. 14, 2016, 9:23 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42322/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 9:23 p.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Bugs: HIVE-12864 > https://issues.apache.org/jira/browse/HIVE-12864 > > > Repository: hive-git > > > Description > ------- > > StackOverflowError parsing queries with very large predicates > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java > 8400ee8cb21e9d8896c9b4f3b50058ed2cb6d983 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > c38699dc80a3e9bee1f5298ef28870aa373d90d3 > ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java > 362a285a8499d82064aa1ae84d811a8700cd3199 > > Diff: https://reviews.apache.org/r/42322/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
