----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42081/#review113549 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java (line 219) <https://reviews.apache.org/r/42081/#comment174281> Could you please be more specific on the reason why "if TS[0] branch for src1 is not optimized, then there is no need to continue processing TS[6] branch? Thanks. - pengcheng xiong On Jan. 8, 2016, 8:16 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42081/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 8:16 p.m.) > > > Review request for hive, Ashutosh Chauhan, pengcheng xiong, and Xuefu Zhang. > > > Bugs: HIVE-12788 > https://issues.apache.org/jira/browse/HIVE-12788 > > > Repository: hive-git > > > Description > ------- > > adds StatsOptimizator support to union with aggregate function. Otherwise, it > always returns one row. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 03c1c3f > ql/src/test/queries/clientpositive/union_remove_26.q PRE-CREATION > ql/src/test/results/clientpositive/union_remove_26.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/42081/diff/ > > > Testing > ------- > > 1. Manual tests for some partitcular cases > 2. submitted to precommit-tests > > > Thanks, > > Chaoyu Tang > >
