----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40589/#review111018 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortUnionReduceRule.java (line 57) <https://reviews.apache.org/r/40589/#comment171014> This is not needed for our Parallel execution env as there is no guarantee that set ops will preserve order. ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortUnionReduceRule.java (line 94) <https://reviews.apache.org/r/40589/#comment171013> In case of pure oder by fetch will be null. Wouldn't "RexLiteral.intValue(sort.fetch)" result in an NPE? - John Pullokkaran On Dec. 16, 2015, 6:46 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40589/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 6:46 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-11775 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 243f281 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortUnionReduceRule.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 36a12bf > ql/src/test/queries/clientpositive/cbo_SortUnionTransposeRule.q > PRE-CREATION > ql/src/test/queries/clientpositive/limit_join_transpose.q 80430c6 > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_3.q cecbbd7 > ql/src/test/results/clientpositive/cbo_SortUnionTransposeRule.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/40589/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
