> On Dec. 11, 2015, 11:21 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 537
> > <https://reviews.apache.org/r/41051/diff/1/?file=1155372#file1155372line537>
> >
> > What about Window Functions that is not valid?
> > Check gen plan if it handles it correctly.
> > If not then that should also be covered.
> >
> > ex: select average(x) over() from t1;
I get the following error which indicates that the average function is invalid,
can you please confirm if it is sufficient.
FAILED: SemanticException Failed to breakup Windowing invocations into Groups.
At least 1 group must only depend on input columns. Also check for circular
dependencies.
Underlying error: Invalid function average
at
org.apache.hadoop.hive.ql.parse.WindowingComponentizer.next(WindowingComponentizer.java:94)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genWindowingPlan(SemanticAnalyzer.java:12041)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPostGroupByBodyPlan(SemanticAnalyzer.java:8877)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genBodyPlan(SemanticAnalyzer.java:8835)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9684)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9577)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genOPTree(SemanticAnalyzer.java:10069)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:10080)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:9941)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:237)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:456)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:310)
...
- Hari Sankar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41051/#review110038
-----------------------------------------------------------
On Dec. 7, 2015, 9:11 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41051/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2015, 9:11 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Incorrect error message Expression not in GROUP BY key thrown instead of
> Invalid function
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java dca3081
> ql/src/test/queries/clientnegative/invalid_select_fn.q PRE-CREATION
> ql/src/test/results/clientnegative/invalid_select_fn.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41051/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
