-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40976/
-----------------------------------------------------------
(Updated Dec. 8, 2015, 10:04 p.m.)
Review request for hive and pengcheng xiong.
Changes
-------
Thanks Pengcheng for taking a closer look. I incorporated all suggested changes
(and some more).
Bugs: HIVE-12595
https://issues.apache.org/jira/browse/HIVE-12595
Repository: hive-git
Description
-------
It seems like there are lot of usage of abstract Operator class where only
possibility is TableScanOp. This results in lot of uncertainty when that
parameter is passed in and is littered with instanceOf checks all over.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java d81e17a
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 9a86a35
ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java
7cf0357
ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java
9509f8e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java dcdc9ba
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRProcContext.java 0da5790
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java af0ac90
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRUnion1.java d3afdc8
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 0cd7b62
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimizer.java
6b04d92
ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinFactory.java 647f863
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java
9b9a5ca
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java
64dc48c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java
130ee89
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java
1d0a254
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java
ea1ece6
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
d0f28d8
ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/ExprProcFactory.java
38040e3
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinFactory.java
aca0630
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnAccessAnalyzer.java ea58917
ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java fe0e234
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 5872e8e
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5803a9c
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkProcContext.java
62237e1
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java 8dc48cd
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java 7e0e137
ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 73e8f6d
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 6ba122a
ql/src/test/org/apache/hadoop/hive/ql/parse/TestGenTezWork.java d9ab9c0
Diff: https://reviews.apache.org/r/40976/diff/
Testing
-------
Refactoring patch. Regression suite suffice.
Thanks,
Ashutosh Chauhan
