-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2676/
-----------------------------------------------------------

Review request for hive, Patrick Hunt, Carl Steinbach, Yongqiang He, Ning 
Zhang, Paul Yang, and namit jain.


Summary
-------

The metastore uses the default hive-log4j.properties only if the 
log4j.configuration system property hasn't already been set.


This addresses bug HIVE-2545.
    https://issues.apache.org/jira/browse/HIVE-2545


Diffs
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1196155 

Diff: https://reviews.apache.org/r/2676/diff


Testing
-------

Verified that this allows the properties file specified in log4j.configuration 
is used if it is specified.

Verified that the default hive-log4j.properties file is used if 
log4j.configuration is not specified.

Verified if the metastore is started via 
     ./hive --service metastore
in the bin directory, the default properties file is used. (I assume this is 
the use case the default was added for from looking at the diff for HIVE-2139)


Thanks,

Kevin

Reply via email to