> On Nov. 3, 2015, 7:02 p.m., Jason Dere wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java, > > line 648 > > <https://reviews.apache.org/r/39909/diff/1/?file=1114773#file1114773line648> > > > > Is this method basically saying that all primitive types are compatible > > with each other? This does not seem like a valid assumption to me - should > > we be using FunctionRegistry.implicitConvertible() or something similar?
I was trying to maintain original logic which allows such conversions. But you are right, we should not allow those conversions. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39909/#review104949 ----------------------------------------------------------- On Nov. 3, 2015, 6 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39909/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 6 p.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-12320 > https://issues.apache.org/jira/browse/HIVE-12320 > > > Repository: hive-git > > > Description > ------- > > hive.metastore.disallow.incompatible.col.type.changes should be true by > default > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > bbaa1ce > ql/src/test/queries/clientpositive/avro_partitioned.q a06e7c4 > ql/src/test/queries/clientpositive/input3.q 2efa7a4 > ql/src/test/queries/clientpositive/orc_int_type_promotion.q 4a805a0 > ql/src/test/queries/clientpositive/parquet_schema_evolution.q af0cf99 > > Diff: https://reviews.apache.org/r/39909/diff/ > > > Testing > ------- > > Existing test suite. > > > Thanks, > > Ashutosh Chauhan > >
