----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39741/#review104481 -----------------------------------------------------------
Ship it! Ship It! - Jimmy Xiang On Oct. 29, 2015, 6:49 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39741/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 6:49 p.m.) > > > Review request for hive. > > > Bugs: HIVE-12280 > https://issues.apache.org/jira/browse/HIVE-12280 > > > Repository: hive-git > > > Description > ------- > > The client calls ZooKeeperHiveClientHelper.configureConnParams() on retry to > get a new HS2 host. But there are some checks to prevent the host/port from > getting reset if they are already set, which will make the retries all try on > the same host/port. > > > Diffs > ----- > > itests/hive-unit/pom.xml 326d646 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestServiceDiscovery.java > PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 6c21423 > > Diff: https://reviews.apache.org/r/39741/diff/ > > > Testing > ------- > > Added unit test. > > > Thanks, > > Szehon Ho > >