[
https://issues.apache.org/jira/browse/HIVE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141337#comment-13141337
]
jirapos...@reviews.apache.org commented on HIVE-2510:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2426/
-----------------------------------------------------------
(Updated 2011-11-01 17:10:08.840622)
Review request for Yongqiang He, Ning Zhang and Kevin Wilfong.
Changes
-------
Made the requested change (not for CTAS database existence is checked in
AnalyzeCreateTable)
Summary
-------
Now when creating table in specific database, if that database doesn't exist
Hive will return an error informing about that, instead of throwing Null
Pointer Exception. Null Pointer happens during semantic analysis, so it seems
reasonable to return an error before the code that would throw null pointer
(Warehouse.getDatabasePath()) executes.
This addresses bug HIVE-2510.
https://issues.apache.org/jira/browse/HIVE-2510
Diffs (updated)
-----
trunk/ql/src/test/queries/clientpositive/input46.q PRE-CREATION
trunk/ql/src/test/results/clientnegative/create_table_failure1.q.out
PRE-CREATION
trunk/ql/src/test/results/clientnegative/create_table_failure2.q.out
PRE-CREATION
trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out
PRE-CREATION
trunk/ql/src/test/results/clientnegative/create_table_failure4.q.out
PRE-CREATION
trunk/ql/src/test/results/clientpositive/input46.q.out PRE-CREATION
trunk/ql/src/test/queries/clientnegative/create_table_failure3.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/create_table_failure4.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/create_table_failure1.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/create_table_failure2.q PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1196082
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1196082
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1196082
Diff: https://reviews.apache.org/r/2426/diff
Testing
-------
Run some sample queries and it seemed to work.
Thanks,
Robert
> Hive throws Null Pointer Exception upon CREATE TABLE <db_name>.<table_name>
> .... if the given <db_name> doesn't exist
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2510
> URL: https://issues.apache.org/jira/browse/HIVE-2510
> Project: Hive
> Issue Type: Bug
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2510.1.patch, HIVE-2510.2.patch, HIVE-2510.3.patch,
> HIVE-2510.4.patch, HIVE-2510.5.patch, HIVE-2510.6.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
