----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29199/#review103701 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 78) <https://reviews.apache.org/r/29199/#comment161769> would Set<String> be more suitable as we are mainly doing .contains() check at run time ? - Thejas Nair On Oct. 23, 2015, 12:12 a.m., Binglin Chang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29199/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 12:12 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-9013: Hive set command exposes metastore db password > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6c7adbd > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 06a83ae > > Diff: https://reviews.apache.org/r/29199/diff/ > > > Testing > ------- > > > Thanks, > > Binglin Chang > >
