----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39026/#review102823 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java (line 603) <https://reviews.apache.org/r/39026/#comment160611> Some javadoc here would be good, as it is seriously non-obvious what you expect to be passed to some of these arguments. metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java (line 2385) <https://reviews.apache.org/r/39026/#comment160612> Is doing the evaluation locally rather than in an HBase filter a for now thing or a forever thing? It seems like it would be much more efficient to do it in a filter. I believe Daniel and Thejas have already written code to handle translating Hive partition expressions into HBase filters. I'm not sure if you could re-use that here or not. - Alan Gates On Oct. 15, 2015, 1:47 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39026/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 1:47 a.m.) > > > Review request for hive, Daniel Dai, Alan Gates, and Thejas Nair. > > > Repository: hive-git > > > Description > ------- > > . > > > Diffs > ----- > > metastore/pom.xml 2ab5cd3 > > metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/Metastore.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ccb4c98 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 136eff5 > > metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java > 5195481 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1968256 > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java > f69b4c7 > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java > df0fac3 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 0f3331a > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 126a2c2 > > metastore/src/test/org/apache/hadoop/hive/metastore/MockPartitionExpressionForMetastore.java > bae1391 > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java > 78a9ea0 > metastore/src/test/org/apache/hadoop/hive/metastore/hbase/MockUtils.java > 6c288f4 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/FileMetaInfo.java 2853119 > ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java > 690b8c9 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java > 9ffa177 > > Diff: https://reviews.apache.org/r/39026/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
