----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39333/#review102762 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 1092 - 1093) <https://reviews.apache.org/r/39333/#comment160522> Please fix the typo "geneation" and elaborate on "0 means don't" -- don't wait or don't batch? If ms means the units are milliseconds, please say so in the description. Shouldn't this use a TimeValidator as in hive.stats.retries.wait and others? - Lefty Leverenz On Oct. 14, 2015, 6:44 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39333/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 6:44 p.m.) > > > Review request for hive, Gopal V and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0fcd39b > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java b03e055 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > c61d615 > > Diff: https://reviews.apache.org/r/39333/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
