----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38123/#review99321 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g (line 222) <https://reviews.apache.org/r/38123/#comment156226> Needs to remove white spaces. metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g (line 439) <https://reviews.apache.org/r/38123/#comment156227> Using COMMA instead of COLON might be a better name and changing the references to it. ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java (line 280) <https://reviews.apache.org/r/38123/#comment156228> Most of the logic here might be redundant once HIVE-11634 goes in. We can decide which one goes in first. ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java (line 429) <https://reviews.apache.org/r/38123/#comment156229> Looked at the entire code, seems like the change is similar to HIVE-11634. Can you please verify with the change in HIVE-11634. ql/src/test/results/clientpositive/pointlookup4.q.out (line 377) <https://reviews.apache.org/r/38123/#comment156230> As noticed before, it looks like partition condition remover doesnt kick in and removes the partition only columns from the predicate. - Hari Sankar Sivarama Subramaniyan On Sept. 4, 2015, 5:49 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38123/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 5:49 a.m.) > > > Review request for hive, Ashutosh Chauhan, Hari Sankar Sivarama Subramaniyan, > and John Pullokkaran. > > > Bugs: HIVE-11726 > https://issues.apache.org/jira/browse/HIVE-11726 > > > Repository: hive-git > > > Description > ------- > > HIVE-11726 > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g > 8aef5bf631361cf4f30f532b9a5fb5e376c06de8 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java > d83636db82ecc1cb891df92736f284b1b29f29c0 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/OpProcFactory.java > 7262164d39547b7832f52873a48ee998219230b1 > ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java > 6a316895aacdd5d26d866c2b0c72ef4407e591e1 > ql/src/test/queries/clientpositive/pointlookup4.q PRE-CREATION > ql/src/test/results/clientpositive/pointlookup4.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/38123/diff/ > > > Testing > ------- > > Existing tests (pointlookup1-4.q) > > > Thanks, > > Jesús Camacho Rodríguez > >
