----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38292/#review98616 -----------------------------------------------------------
common/src/java/org/apache/hive/common/util/ShutdownHookManager.java (line 59) <https://reviews.apache.org/r/38292/#comment155142> Side question: I'm wondering why we need two methods which are the same thing. Could we get rid of one? - Xuefu Zhang On Sept. 11, 2015, 5:54 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38292/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 5:54 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > More than 490,000 paths was added to java.io.DeleteOnExitHook on one of our > long running HiveServer2 instances,taken up more than 100MB on heap. > Most of the paths contains a suffix of ".pipeout". > > > Diffs > ----- > > common/src/java/org/apache/hive/common/util/ShutdownHookManager.java > fd2f20a > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 7ed8e5f > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > bcc66cf > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > cc9df76 > > Diff: https://reviews.apache.org/r/38292/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >