----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2595/#review2918 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java <https://reviews.apache.org/r/2595/#comment6526> In the example above, (hr='1', ds='2011-01-01') will work. It should not work - it would be simpler if you check the order also trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java <https://reviews.apache.org/r/2595/#comment6527> add some comments trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java <https://reviews.apache.org/r/2595/#comment6528> 1 for loop instead of 2 for loops trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java <https://reviews.apache.org/r/2595/#comment6529> I think there is a bug here - not sure Why have a for loop - you are returning inside if anyway the first time ? - namit On 2011-10-28 18:28:45, Yongqiang He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2595/ > ----------------------------------------------------------- > > (Updated 2011-10-28 18:28:45) > > > Review request for hive and namit jain. > > > Summary > ------- > > Support archiving for multiple partitions if the table is partitioned by > multiple columns > > > This addresses bug HIVE-2278. > https://issues.apache.org/jira/browse/HIVE-2278 > > > Diffs > ----- > > trunk/data/files/archive_corrupt.rc UNKNOWN > trunk/metastore/if/hive_metastore.thrift 1188906 > trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h 1188906 > trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp 1188906 > > trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java > 1188906 > > trunk/metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php > 1188906 > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/constants.py 1188906 > trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb 1188906 > trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1188906 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java > PRE-CREATION > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1188906 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1188906 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 1188906 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java > 1188906 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1188906 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1188906 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1188906 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1188906 > trunk/ql/src/test/queries/clientnegative/archive_insert1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert3.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert4.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi3.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi4.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi5.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi6.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi7.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec3.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/archive_corrupt.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/archive_multi.q PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive1.q.out 1188906 > trunk/ql/src/test/results/clientnegative/archive2.q.out 1188906 > trunk/ql/src/test/results/clientnegative/archive_insert1.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert2.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert3.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert4.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi1.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi2.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi3.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi4.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi5.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi6.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi7.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec1.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec2.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out > PRE-CREATION > trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/archive_multi.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/2595/diff > > > Testing > ------- > > Support archiving for multiple partitions if the table is partitioned by > multiple columns > > > Thanks, > > Yongqiang > >
