> On Aug. 21, 2015, 10:09 p.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/server/HiveServer2.java, line 274 > > <https://reviews.apache.org/r/37660/diff/2/?file=1045405#file1045405line274> > > > > do we need to publish the password based authentication modes ?
Don't think so, because JDBC driver has either NOSASL, KERBEROS (determined by the presence of principal in connection string) or password based (all others). I agree there is scope for improvement in how we encode that in the driver, but I guess we can work on it in a new jira focussed on improving that. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37660/#review96087 ----------------------------------------------------------- On Aug. 20, 2015, 10:04 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37660/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 10:04 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-11581 > https://issues.apache.org/jira/browse/HIVE-11581 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-11581 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9a6781b > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java bb2b695 > jdbc/src/java/org/apache/hive/jdbc/Utils.java 0e4693b > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java e24b3dc > service/src/java/org/apache/hive/service/server/HiveServer2.java 4a4be97 > > Diff: https://reviews.apache.org/r/37660/diff/ > > > Testing > ------- > > Manually, will publish test matrix shortly. > > > Thanks, > > Vaibhav Gumashta > >