> On Aug. 19, 2015, 6:17 p.m., Xuefu Zhang wrote: > > Thanks, guys. However, I do see that the solution seems complicated and > > error-prone. It will be great if we can simplify this. > > Jimmy Xiang wrote: > To support recursive type, so far, I don't see a better solution. We can > enhance it if someone comes up a better solution later on. Thanks. > > Xuefu Zhang wrote: > I think the part of complexity may come from the fact that the > synchronization happens in different files. It might become cleaner if we can > somehow refector the code so that synchonization blocks stay in the same file. > > Jimmy Xiang wrote: > That's an interesting idea. But ThriftUnionObjectInspector and > ReflectionStructObjectInspector have different init logic. How can we > refactor them into a same file? That may introduce more changes, right? > > Xuefu Zhang wrote: > I don't know. I was thinking that some helper methods in a util class > should help.
But it will make things more complex. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37591/#review95866 ----------------------------------------------------------- On Aug. 18, 2015, 9:51 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37591/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 9:51 p.m.) > > > Review request for hive. > > > Bugs: HIVE-11586 > https://issues.apache.org/jira/browse/HIVE-11586 > > > Repository: hive-git > > > Description > ------- > > Made ObjectInspectorFactory.getReflectionObjectInspector thread-safe. When it > returns, the object inspector is fully initialized. > > > Diffs > ----- > > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java > 97bb715 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java > 78e6066 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ThriftUnionObjectInspector.java > 600abbb > > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestReflectionObjectInspectors.java > e2408c6 > > Diff: https://reviews.apache.org/r/37591/diff/ > > > Testing > ------- > > Unit test > > > Thanks, > > Jimmy Xiang > >
