[ https://issues.apache.org/jira/browse/HIVE-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138341#comment-13138341 ]
jirapos...@reviews.apache.org commented on HIVE-2465: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2066/ ----------------------------------------------------------- (Updated 2011-10-28 13:45:50.702623) Review request for hive. Changes ------- Log level is changed to Log.debug instead of Log.info. If it is warn also it might generate lot of log because by default log level Log.INFO is configured Summary ------- Primitive Data Types returning null if the data is out of range of the data type. Added log message while returning null to know some of the data is out of range. This addresses bug HIVE-2465. https://issues.apache.org/jira/browse/HIVE-2465 Diffs (updated) ----- trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBoolean.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyByte.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyDouble.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFloat.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyInteger.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyLong.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyPrimitive.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyShort.java 1190202 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java 1190202 trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java 1190202 Diff: https://reviews.apache.org/r/2066/diff Testing ------- All tests passed Thanks, chinna > Primitive Data Types returning null if the data is out of range of the data > type. > --------------------------------------------------------------------------------- > > Key: HIVE-2465 > URL: https://issues.apache.org/jira/browse/HIVE-2465 > Project: Hive > Issue Type: Bug > Components: Query Processor > Affects Versions: 0.9.0 > Environment: Hadoop 0.20.1, Hive0.9.0 and SUSE Linux Enterprise > Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5) > Reporter: Chinna Rao Lalam > Assignee: Chinna Rao Lalam > Attachments: HIVE-2465.1.patch, HIVE-2465.2.patch, HIVE-2465.patch > > > Primitive Data Types returning null if the input data is out of range of the > data type. In this case it is better to log the message with the proper > message and actual data then user get to know some data is missing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira