----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37150/#review94484 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java (line 532) <https://reviews.apache.org/r/37150/#comment149110> why only this case cannot be folded? seems like the other cases, like "not (key < 3 and key is not null" would also have the same issue. ql/src/test/queries/clientpositive/folder_predicate.q (line 7) <https://reviews.apache.org/r/37150/#comment149111> maybe add tests negation as well? e.g.: SELECT * FROM predicate_fold_tb WHERE NOT (value IS NOT NULL AND value >= 3); - Chao Sun On Aug. 6, 2015, 12:01 a.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37150/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 12:01 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x > <> 0) > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java > 410735c27e5372a0818e18e1a6dc5b07d7b986c0 > ql/src/test/queries/clientpositive/folder_predicate.q PRE-CREATION > ql/src/test/results/clientpositive/folder_predicate.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/37150/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
